Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky TestLeaseKeepAliveOneSecond #19473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix flaky TestLeaseKeepAliveOneSecond #19473

wants to merge 1 commit into from

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Feb 24, 2025

Refer to https://github.com/etcd-io/etcd/actions/runs/13499481627/job/37714129702?pr=19426

    cluster.go:242:  - m0 -> 2f0c1931b70c09a2 (unix://localhost:m0)
    lease_test.go:211: chan is closed, want not closed
    lease_test.go:211: chan is closed, want not closed

@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (2de17bd) to head (4cef06b).
Report is 3 commits behind head on main.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19473      +/-   ##
==========================================
+ Coverage   68.84%   68.91%   +0.06%     
==========================================
  Files         420      420              
  Lines       35762    35762              
==========================================
+ Hits        24622    24647      +25     
+ Misses       9714     9693      -21     
+ Partials     1426     1422       -4

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 022b9b2...4cef06b. Read the comment docs.

@ahrtr
Copy link
Member Author

ahrtr commented Feb 24, 2025

/retest

@ahrtr
Copy link
Member Author

ahrtr commented Feb 24, 2025

@fuweid

fuweid
fuweid approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Member Author

ahrtr commented Feb 25, 2025

cc @jmhbnz @serathius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
approved area/testing size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahrtr @k8s-ci-robot @fuweid